<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Wed, 2011-01-05 at 08:48 +1000, Peter Hutterer wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#1a1a1a">same goes here btw, it'd be much nicer to read if you could swap $1</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">etc. over for meaningful names. just reading this context, I'd have no</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">idea what the error would convey.</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">same goes for e.g. process() too. but this can be a follow-up patch</FONT></TT><BR>
<BR>
</BLOCKQUOTE>
I have a TODO to fix them all, now that I have a sample one reviewed.<BR>
<BR>
Same for Dan's suggestion regarding removal of superfluous fallback case.<BR>
<TT><FONT COLOR="#737373"> *)</FONT></TT><BR>
<TT><FONT COLOR="#737373"> ;;</FONT></TT><BR>
<BR>
Thanks
</BODY>
</HTML>