[PATCH 01/21] include: add GetXI2MaskByte and GetXI2EventFilterMask to headers

Peter Hutterer peter.hutterer at who-t.net
Tue Dec 20 14:25:25 PST 2011


On Tue, Dec 20, 2011 at 11:46:27AM -0500, Adam Jackson wrote:
> On 12/8/11 10:36 PM, Peter Hutterer wrote:
> 
> >@@ -414,7 +414,7 @@ GetEventFilterMask(DeviceIntPtr dev, int evtype)
> >      return filters[dev ? dev->id : 0][evtype];
> >  }
> >
> >-static inline Mask
> >+inline Mask
> >  GetXI2EventFilterMask(int evtype)
> >  {
> >      return (1<<  (evtype % 8));
> 
> This reads strangely to me.  I don't remember whether saying
> 'inline' like that is legal and/or works, but it's certainly
> unnecessary.  I'd take it out for clarity.

The inline was removed in adf8a0d62c0643f4c44a3b6d2e3c6c9b02532915 when
those functions were moved to inpututils and renamed to
event_get_filter_from_xi2type. That's already on master, so I'll skip 
trying to slot in a patch here :)

Cheers,
  Peter


More information about the xorg-devel mailing list