[PATCH 01/21] include: add GetXI2MaskByte and GetXI2EventFilterMask to headers

Adam Jackson ajax at nwnk.net
Tue Dec 20 08:46:27 PST 2011


On 12/8/11 10:36 PM, Peter Hutterer wrote:

> @@ -414,7 +414,7 @@ GetEventFilterMask(DeviceIntPtr dev, int evtype)
>       return filters[dev ? dev->id : 0][evtype];
>   }
>
> -static inline Mask
> +inline Mask
>   GetXI2EventFilterMask(int evtype)
>   {
>       return (1<<  (evtype % 8));

This reads strangely to me.  I don't remember whether saying 'inline' 
like that is legal and/or works, but it's certainly unnecessary.  I'd 
take it out for clarity.

- ajax


More information about the xorg-devel mailing list