[PATCH 1/4] savage: Fix logic in waitHSync

Alex Deucher alexdeucher at gmail.com
Wed Apr 20 21:57:37 PDT 2011


On Wed, Apr 20, 2011 at 6:08 PM, Tormod Volden <lists.tormod at gmail.com> wrote:
> On Wed, Apr 20, 2011 at 11:36 PM, Matt Turner wrote:
>> Man, somebody didn't know operator precedence. Probably good that git
>> history doesn't go back that far. :)
>
> BTW, I just learned about -Wlogical-op (not part of -Wall) which
> unfortunately does not catch this issue. But it found some similar
> mix-ups like "register && bit-mask"... Coming up next.
>

This series and the &/&& patch look good to me.

Reviewed-by: Alex Deucher <alexdeucher at gmail.com>

>> For the series:
>> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
> Thanks!
> Tormod
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>


More information about the xorg-devel mailing list