[PATCH 1/4] savage: Fix logic in waitHSync

Tormod Volden lists.tormod at gmail.com
Wed Apr 20 15:08:20 PDT 2011


On Wed, Apr 20, 2011 at 11:36 PM, Matt Turner wrote:
> Man, somebody didn't know operator precedence. Probably good that git
> history doesn't go back that far. :)

BTW, I just learned about -Wlogical-op (not part of -Wall) which
unfortunately does not catch this issue. But it found some similar
mix-ups like "register && bit-mask"... Coming up next.

> For the series:
> Reviewed-by: Matt Turner <mattst88 at gmail.com>

Thanks!
Tormod


More information about the xorg-devel mailing list