[PATCH] [RFC] dix/mi: remove ChangeWindowAttributes from rendering path.

[Dave Airlie]

On Tue, Apr 5, 2011 at 7:37 AM, Aaron Plattner <aplattner at nvidia.com> wrote:
> On Mon, Apr 04, 2011 at 02:26:42PM -0700, Dave Airlie wrote:
>> On Tue, Apr 5, 2011 at 6:42 AM, Aaron Plattner <aplattner at nvidia.com> wrote:
>> > On Mon, Apr 04, 2011 at 01:24:10PM -0700, Dave Airlie wrote:
>> >> > Are you planning on leaving the ChangeWindowAttrbutes screen hook there, or
>> >> > is it slated for deletion?  I ask because we currently wrap CWA so we can
>> >> > watch for colormap changes on PseduoColor windows.
>> >> >
>> >>
>> >> Can you give me a why?
>> >
>> > ftp://download.nvidia.com/XFree86/Linux-x86/270.30/README/xconfigoptions.html#cioverlay
>> >
>> > When the colormap changes, we need to flush the updates through to the
>> > hardware.
>>
>> Okay is there a better time to do this? CWA doesn't seem like a thing
>> that should be hitting hardware,
>
> I don't think there's anything else that happens when a non-installed
> colormap changes, is there?
>
>> how many colormaps can you have in the hardware? one? one per window?
>> etc. Just wondering is
>> it really associated with the Screen and not the Window etc.
>
> I know it's funky, but that overlay mode doesn't actually look at the
> installed map, but rather the map associated with each window.  Updates to
> the colormap take effect immediately and apply directly to the
> corresponding window.  All of the windows are displayed with correct colors
> simultaneously.

This is what I don't understand, does the hw understand what a Window is?

Do you give it window clips and all that and correspond colormaps to them?

The driver interface should reflect what the hw is doing, if they hw
has only one colormap
then we add a hook to update the driver colormap in the right place
and remove CWA.

I don't really need to understand how the driver works currently as
clearly its designed
around the current X model so does things within its limitations, I'm
trying to find how
to design an interface your driver could use and still get the same features.

Dave.