removing PCI dependency from xserver

Tiago Vignatti tiago.vignatti at nokia.com
Wed Sep 1 08:00:57 PDT 2010


Hi all,

Right now, we have two impediments preventing me to put libpciaccess optional
in xserver:

1. fbdevhw module, which is PCI tied
2. IOADDRESS type (weird) definition


My last attempt to get rid of PCI in fbdevhw [0] was only commented by Mark
Kettenis. He mainly pointed the existence of fbdevhw. For instance, if it
should go to Linux specific directory (which for me is off topic, but totally
valid argument) or if the relation PCI <-> fbdevhw should be kept (which is
not true; I had already an OMAP based device without PCI using fbdevhw
interface). What you thing?

For 2. I tried an approach, that Mark also commented [1], but maybe I should be
more carefully, explained better my intention. Mark basically complains that my
patch hinders readability. But I'm against with his argument: all variables
using IOADDRESS in such patch has a very suggestive name. Anyway, after all,
all the code on the whole patch is due to be removed soon (GetClocks is a hack
and domainIO/domainIOBase is remnants of entity resource code). To remove this
code requires too much manual effort now though.


Please, I need feedback here to keep with this work. Mark, do you have some
suggestions how to proceed? Once I've done with 1. and .2 I can roll my
bus-cleanup-take3 tree [2] again and conditionalize libpciaccess from the
server.


Thank you,


[0] http://lists.x.org/archives/xorg-devel/2010-August/012332.html
[1] http://lists.x.org/archives/xorg-devel/2010-June/009555.html
[2] http://cgit.freedesktop.org/~vignatti/xserver/log/?h=bus-cleanup-take3

             Tiago


More information about the xorg-devel mailing list