[PATCH] configure.ac: Add -fno-strict-aliasing to CFLAGS

[Gaetan Nadon]

On Sat, 2010-10-30 at 15:02 -0700, Jeremy Huddleston wrote:

> diff --git a/configure.ac b/configure.ac
> index e8f9473..01c5196 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -83,6 +83,12 @@ AC_PROG_SED
>  # easier overrides at build time.
>  XSERVER_CFLAGS='$(CWARNFLAGS)'
>  
> +dnl Explicitly add -fno-strict-aliasing since this option should
> disappear
> +dln from util-macros CWARNFLAGS
> +if  test "x$GCC" = xyes ; then
> +    XSERVER_CFLAGS="$XSERVER_CFLAGS -fno-strict-aliasing"
> +fi
> +
> 

The server is currently (git master) compiling with this option, and has
been for longest time. This patch will simply duplicate this option. In
bug 31238:

        The configure script in the three most recent releases of xorg-server define
        CWARNFLAGS without -fno-strict-aliasing.

The xserver tarball 1.9.1 requires util-macros tarball 1.10 which does
contain this option.

In Gentoo bug 339988:

        So I think upstream are building their releases with a version of
        xorg-macros.m4 that doesn't correspond to any tagged version in git. Every
        version since util-macros-1.2.0 has -fno-strict-aliasing.

My interpretation is that the xserver code anywhere in git is correct
and that the problem lies in the incorrectly built xserver tarball. A
naive suggestion would be to bump version the number and respin a new
tarball after fixing the build environment. The xserver tarball should
obviously not be configured with a util-macros package that does not
correspond to any tagged version in git.

With the patch, we will see the duplicate option which will raise
questions every now and then. Even if the patch was meant for 1.9.1 or
1.9.2, it's still not needed to be the problem.

Gaetan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101031/df57df21/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101031/df57df21/attachment.pgp>