<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Sat, 2010-10-30 at 15:02 -0700, Jeremy Huddleston wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#1a1a1a">diff --git a/configure.ac b/configure.ac</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">index e8f9473..01c5196 100644</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">--- a/configure.ac</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+++ b/configure.ac</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">@@ -83,6 +83,12 @@ AC_PROG_SED</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> # easier overrides at build time.</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> XSERVER_CFLAGS='$(CWARNFLAGS)'</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> </FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+dnl Explicitly add -fno-strict-aliasing since this option should disappear</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+dln from util-macros CWARNFLAGS</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+if test "x$GCC" = xyes ; then</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+ XSERVER_CFLAGS="$XSERVER_CFLAGS -fno-strict-aliasing"</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+fi</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+</FONT></TT><BR>
<BR>
</BLOCKQUOTE>
The server is currently (git master) compiling with this option, and has been for longest time. This patch will simply duplicate this option. In bug 31238:
<BLOCKQUOTE>
<PRE>
The configure script in the three most recent releases of xorg-server define
CWARNFLAGS without -fno-strict-aliasing.
</PRE>
</BLOCKQUOTE>
The xserver tarball 1.9.1 requires util-macros tarball 1.10 which does contain this option.<BR>
<BR>
In Gentoo bug 339988:
<BLOCKQUOTE>
<PRE>
So I think upstream are building their releases with a version of
xorg-macros.m4 that doesn't correspond to any tagged version in git. Every
version since util-macros-1.2.0 has -fno-strict-aliasing.
</PRE>
</BLOCKQUOTE>
My interpretation is that the xserver code anywhere in git is correct and that the problem lies in the incorrectly built xserver tarball. A naive suggestion would be to bump version the number and respin a new tarball after fixing the build environment. The xserver tarball should obviously not be configured with a util-macros package that does not correspond to any tagged version in git.<BR>
<BR>
With the patch, we will see the duplicate option which will raise questions every now and then. Even if the patch was meant for 1.9.1 or 1.9.2, it's still not needed to be the problem.<BR>
<BR>
Gaetan
</BODY>
</HTML>