[PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

Mikhail Gusarov dottedmag at dottedmag.net
Tue Oct 19 03:24:19 PDT 2010


Twas brillig at 12:18:06 19.10.2010 UTC+02 when jcristau at debian.org did
gyre and gimble:

 >>  wh> malloc will return (void *) so there is no need to cast.
 >>  wh> i do not know xmalloc() but i see no check for OOM condition.
 >>  wh> instead of removing xmalloc() it would be more useful to follow
 >>  wh> XtMalloc() that has error handling inside.
 >> 
 >> Sho what's the reasonable error strategy? Shut down the server?
                             ^ default

 JC> You could fail preinit for that driver.  But I guess if you're OOM
 JC> at preinit time, you're not going to go much further anyway.

XtMalloc calls XtErrorMsg if there is no memory available. Not really
useful.

-- 
  http://fossarchy.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101019/c8382409/attachment-0001.pgp>


More information about the xorg-devel mailing list