[PATCH xf86-input-joystick 1/2] Deprecated code cleanup.

Julien Cristau jcristau at debian.org
Tue Oct 19 03:18:06 PDT 2010


On Tue, Oct 19, 2010 at 14:03:54 +0400, Mikhail Gusarov wrote:

> 
> Twas brillig at 10:07:23 19.10.2010 UTC+02 when wharms at bfs.de did gyre and gimble:
> 
>  wh> malloc will return (void *) so there is no need to cast.
>  wh> i do not know xmalloc() but i see no check for OOM condition.
>  wh> instead of removing xmalloc() it would be more useful to follow
>  wh> XtMalloc() that has error handling inside.
> 
> Sho what's the reasonable error strategy? Shut down the server?
> 
You could fail preinit for that driver.  But I guess if you're OOM at
preinit time, you're not going to go much further anyway.

Cheers,
Julien


More information about the xorg-devel mailing list