[PATCH modular 1/3] Process a user-supplied list of module/components.

[Gaetan Nadon]

On Mon, 2010-10-04 at 06:54 -0400, Trevor Woerner wrote:

> From: Trevor Woerner <twoerner at gmail.com>
> 
> New feature. Allow the user to supply, on the cmdline, a
> space-separated list
> of module/components to process, the script will process only those
> listed
> module/components. The list can be in any arbitrary order, the script
> takes
> care to process them in their correct, dependency order. Warn the user
> should
> there be any module/components from the list which aren't processed
> (probably
> due to misspelling).
> 
> Suggested usage:
> 1. run the script, only generating the list of modules, redirected to
> a file
> $ build.sh -L > list
> 
> 2. edit list, removing any unneeded module/components
> 
> 3. run the build as follows:
> $ build.sh $PREFIX --modlist "`cat list`" ...
> 
> 

Looks great. There may be some improvements to be done on the cmd line
error checking.
Not that the problems are introduced by the patch, but because the patch
makes the usage
of the cmd line less trivial than it use to be, it needs to be more
robust.

For example, if I invoke the script from the modular directory, with
$PREFIX unset:

        ./build.sh --modlist

I get: shift: 1072: can't shift that many

        ./build.sh --bad

attempts to run the whole build and claims at the end that no modules
were available.

If I invoke the script from $PREFIX directory (as it should be):

        ./build.sh --modlist

I get: shift: 1072: can't shift that many 

        ./build.sh --bad

attempts to run the whole build and I get:

        aclocal: couldn't open directory `--bad/share/aclocal': No such file or directory

This is not going to be easy to figure out for casual users.


Suggestion: it would make life easier if there was a way so provide the
filename containing the module list.
It's unlikely someone will be typing anything more than one module name.

Gaetan





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101004/31fb6f8b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101004/31fb6f8b/attachment.pgp>