<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Mon, 2010-10-04 at 06:54 -0400, Trevor Woerner wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#1a1a1a">From: Trevor Woerner <<A HREF="mailto:twoerner@gmail.com">twoerner@gmail.com</A>></FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">New feature. Allow the user to supply, on the cmdline, a space-separated list</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">of module/components to process, the script will process only those listed</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">module/components. The list can be in any arbitrary order, the script takes</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">care to process them in their correct, dependency order. Warn the user should</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">there be any module/components from the list which aren't processed (probably</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">due to misspelling).</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">Suggested usage:</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">1. run the script, only generating the list of modules, redirected to a file</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">$ build.sh -L > list</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">2. edit list, removing any unneeded module/components</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">3. run the build as follows:</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">$ build.sh $PREFIX --modlist "`cat list`" ...</FONT></TT><BR>
<BR>
<BR>
</BLOCKQUOTE>
Looks great. There may be some improvements to be done on the cmd line error checking.<BR>
Not that the problems are introduced by the patch, but because the patch makes the usage<BR>
of the cmd line less trivial than it use to be, it needs to be more robust.<BR>
<BR>
For example, if I invoke the script from the modular directory, with $PREFIX unset:
<BLOCKQUOTE>
<PRE>
./build.sh --modlist
</PRE>
</BLOCKQUOTE>
I get: shift: 1072: can't shift that many
<BLOCKQUOTE>
<PRE>
./build.sh --bad
</PRE>
</BLOCKQUOTE>
attempts to run the whole build and claims at the end that no modules were available.<BR>
<BR>
If I invoke the script from $PREFIX directory (as it should be):
<BLOCKQUOTE>
<PRE>
./build.sh --modlist
</PRE>
</BLOCKQUOTE>
I get: shift: 1072: can't shift that many
<BLOCKQUOTE>
<PRE>
./build.sh --bad
</PRE>
</BLOCKQUOTE>
attempts to run the whole build and I get:
<BLOCKQUOTE>
<PRE>
aclocal: couldn't open directory `--bad/share/aclocal': No such file or directory
</PRE>
</BLOCKQUOTE>
This is not going to be easy to figure out for casual users.<BR>
<BR>
<BR>
Suggestion: it would make life easier if there was a way so provide the filename containing the module list.<BR>
It's unlikely someone will be typing anything more than one module name.<BR>
<BR>
Gaetan<BR>
<BR>
<BR>
<BR>
<BR>
<BR>
</BODY>
</HTML>