[PATCH] Don't ValidateTree/expose when changing the input shape

[Pierre-Loup A. Griffais]

On 05/27/2010 04:13 AM, Daniel Stone wrote:
> * PGP Signed by an unknown key
>
> On Wed, May 26, 2010 at 04:57:02PM -0700, Pierre-Loup A. Griffais wrote:
>> ValidateTree can be pretty expensive; gnome-shell floods the server with
>> input shape requests when animating windows, so that change makes it
>> perform a lot better.
>>
>> Aaron suggested Keith and Adam as reviewers; are the SetWinSize,
>> SetBorderSize, ResizeChildrenWinSize also unneeded when changing the
>> input shape? The only thing that looks needed for sure is
>> CheckCursorConfinement(), but I have my doubts about the rest.
>
> You don't need to call any of SetWinSize, SetBorderSize, or
> ResizeChildrenWinSize, which are also moderately hostile.  So if you
> skipped those three for changes only to the input shape:
> Reviewed-by: Daniel Stone<daniel at fooishbar.org>

Great, thanks a lot. New patch attached that explicitly conditionalizes most of 
the function depending on the shape kind at Keith's suggestion. Indenting the 
new block caused my editor to destroy all the tabs, so I had to touch up the 
style of most of the function; sorry that makes the patch hard to read. Also 
updated the commit message to reflect the more general approach of the change.

Thanks!
  - Pierre-Loup

>
> Cheers,
> Daniel
>
> * Unknown Key
> * 0xB2808094