[PATCH] Don't ValidateTree/expose when changing the input shape

Daniel Stone daniel at fooishbar.org
Thu May 27 04:13:51 PDT 2010


On Wed, May 26, 2010 at 04:57:02PM -0700, Pierre-Loup A. Griffais wrote:
> ValidateTree can be pretty expensive; gnome-shell floods the server with 
> input shape requests when animating windows, so that change makes it 
> perform a lot better.
>
> Aaron suggested Keith and Adam as reviewers; are the SetWinSize, 
> SetBorderSize, ResizeChildrenWinSize also unneeded when changing the 
> input shape? The only thing that looks needed for sure is 
> CheckCursorConfinement(), but I have my doubts about the rest.

You don't need to call any of SetWinSize, SetBorderSize, or
ResizeChildrenWinSize, which are also moderately hostile.  So if you
skipped those three for changes only to the input shape:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100527/b316deb3/attachment.pgp>


More information about the xorg-devel mailing list