[PATCH 3/5] Replace some input devPrivates with regular struct fields

Simon Thum simon.thum at gmx.de
Fri May 7 11:43:38 PDT 2010


Am 02.05.2010 22:50, schrieb Keith Packard:
> On Sun, 2 May 2010 09:11:53 -0700, Jamey Sharp <jamey at minilop.net> wrote:
> 
>>> Would you agree to revert the ptrveloc.* part of the patch? I'd rather
>>> fix this when fixing the accel setup. The scheme stuff isn't fully
>>> worked out, but the props really belong there.
> 
> Feel free to use a union or some other datatype, but I don't see why DIX
> would need to use a devPrivate for internal operation. Or even just
> separate pointers; storage is not a significant issue for devices, and
> avoiding devPrivates means that the code can be simpler and clearer.
> 
> And, it's never too late to go back to the old code if that seems sensible.
I think I'll be preparing something on top of that, but it won't land
tomorrow.

Cheers,

Simon



More information about the xorg-devel mailing list