[PATCH 3/5] Replace some input devPrivates with regular struct fields

Keith Packard keithp at keithp.com
Sun May 2 13:50:47 PDT 2010


On Sun, 2 May 2010 09:11:53 -0700, Jamey Sharp <jamey at minilop.net> wrote:

> > Would you agree to revert the ptrveloc.* part of the patch? I'd rather
> > fix this when fixing the accel setup. The scheme stuff isn't fully
> > worked out, but the props really belong there.

Feel free to use a union or some other datatype, but I don't see why DIX
would need to use a devPrivate for internal operation. Or even just
separate pointers; storage is not a significant issue for devices, and
avoiding devPrivates means that the code can be simpler and clearer.

And, it's never too late to go back to the old code if that seems sensible.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100502/f520dd54/attachment.pgp>


More information about the xorg-devel mailing list