clang static analysis of xorg-server

[Matthias Hopf]

On Mar 22, 10 17:50:38 -0700, Jeremy Huddleston wrote:
> Actually, it was a valid error.  The assignment was doing |= rather than =, 
> and the current value was garbage.

?  |= looks correct.

Alan's comment is perfectly correct. 1L << 31 is undefined on
architectures that define long to have 32 bit. As most architectures use
2's complement for negative values this shouldn't have any negative side
effect, though.

Thanks for the work on clang

Matthias

-- 
Matthias Hopf <mhopf at suse.de>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat at mshopf.de
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de