clang static analysis of xorg-server

[Jeremy Huddleston]

Actually, it was a valid error.  The assignment was doing |= rather  
than =, and the current value was garbage.



On Mar 22, 2010, at 14:08, Alan Coopersmith wrote:

> Jeremy Huddleston wrote:
>> I aree ... some of the "dead store" issues are more stylistic or  
>> future proofing.
>>
>> The real ones we should consider are the logic errors... garbage  
>> assignment and null dereference.
>>
>> Some of the errors seem outright bogus (http://people.freedesktop.org/~jeremyhu/clang/2010-03-22-1/report-K6CxIC.html#EndPath 
>> ), so if you see any others like that, let me know.  I'm building  
>> the latest version of clang right now, and if those oddities are  
>> still present, I'll report them to the developers.
>
> That might be pointing out that the definition of  
> XkbControlsEnabledMask is
> technically undefined on a 32-bit system, since it should be (1UL <<  
> 31) not
> (1L << 31) - we've gotten that error in various tools before.
>
> -- 
> 	-Alan Coopersmith-           alan.coopersmith at sun.com
> 	 Oracle Solaris Platform Engineering: X Window System
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5820 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100322/0c39e14f/attachment-0001.bin>