clang static analysis of xorg-server

[Jeremy Huddleston]

I aree ... some of the "dead store" issues are more stylistic or future proofing.

The real ones we should consider are the logic errors... garbage assignment and null dereference.

Some of the errors seem outright bogus (http://people.freedesktop.org/~jeremyhu/clang/2010-03-22-1/report-K6CxIC.html#EndPath), so if you see any others like that, let me know.  I'm building the latest version of clang right now, and if those oddities are still present, I'll report them to the developers.





On Mar 22, 2010, at 10:25, Matthias Hopf wrote:

> On Mar 22, 10 09:58:59 -0700, Jeremy Huddleston wrote:
>> I ran the static analyzer on a build of the current git master of xorg-server.  Here are the results:
>> http://people.freedesktop.org/~jeremyhu/clang/2010-03-22-1/
>> There are quite a number of hidden issues.  Would people find it useful to have this data part of tinderbox.x.org?  If so, I'll look into seeing how easily it would be to integrate clang into jhbuild.
> 
> While 'rand is a poor random generator' and 'Dead assignment' are
> questionable, at least some of the NULL pointer accesses seem real.
> 
> It might be interesting to have this on tinderbox, however, there should
> be a possibility to mark false positives (like the use of rand() in not
> security critical code). Any ideas?
> 
> Thanks for the test
> 
> Matthias
> 
> -- 
> Matthias Hopf <mhopf at suse.de>      __        __   __
> Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat at mshopf.de
> Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5820 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100322/413385e5/attachment.bin>