[PATCH] edid: Fix the HDTV sync pulse adjustment

[Adam Jackson]

On Tue, 2010-07-27 at 19:20 -0500, Pat Kane wrote:
> Reviewed-by: Patrick E. Kane <pekane52 at gmail.com>
> 
> The lines of context appear to show that both hsize and vsize are being
> changed, could include a comment to explain why only HSync* needs to
> be adjusted?

This quirk only happens for standard mode codes, which in EDID are a
tuple of (width in character cells starting from some offset, aspect
ratio, refresh rate).  By this point in mode parse we've converted that
to be (width in pixels, height in pixels, refresh rate).  Height is
derived from the (too coarse-grained) width and aspect ratio, so the
heights we're checking for are just whatever the math ends up giving
you.

The corresponding kernel code is a bit cleaner, in that the math is all
in one place:

http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=blob;f=drivers/gpu/drm/drm_edid.c;h=f87bf104df7a4cc79b2991759c88e00246cf64d4;hb=a4967de6cbb260ad0f6612a1d2035e119ef1578f#l809

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100729/e39964f2/attachment.pgp>