[PATCH] edid: Fix the HDTV sync pulse adjustment

Pat Kane pekane52 at gmail.com
Tue Jul 27 17:20:07 PDT 2010


Reviewed-by: Patrick E. Kane <pekane52 at gmail.com>

The lines of context appear to show that both hsize and vsize are being
changed, could include a comment to explain why only HSync* needs to
be adjusted?

In any event, thanks for the patch.

Pat
---

On Tue, Jul 27, 2010 at 4:34 PM, Adam Jackson <ajax at redhat.com> wrote:
> Simple typo, should have been adjusting the horizontal timings
> consistently since we're not trying to mangle vertical at all.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  hw/xfree86/modes/xf86EdidModes.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/xfree86/modes/xf86EdidModes.c b/hw/xfree86/modes/xf86EdidModes.c
> index 8f4d04f..a94379f 100644
> --- a/hw/xfree86/modes/xf86EdidModes.c
> +++ b/hw/xfree86/modes/xf86EdidModes.c
> @@ -484,8 +484,8 @@ DDCModesFromStandardTiming(struct std_timings *timing, ddc_quirk_t quirks,
>             (hsize == 1368 && vsize == 769))) {
>            Mode = xf86CVTMode(1366, 768, 60, FALSE, FALSE);
>            Mode->HDisplay = 1366;
> -           Mode->VSyncStart--;
> -           Mode->VSyncEnd--;
> +           Mode->HSyncStart--;
> +           Mode->HSyncEnd--;
>        } else if (hsize && vsize && refresh) {
>            Mode = FindDMTMode(hsize, vsize, refresh, rb);
>
> --
> 1.7.1.1
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>


More information about the xorg-devel mailing list