[PATCH] Remove unused facility to build modes code from uninstalled server.

Aaron Plattner aplattner at nvidia.com
Tue Jul 13 08:54:18 PDT 2010


On Tue, Jul 13, 2010 at 06:39:23AM -0700, Gaetan Nadon wrote:
> This driver only configures against xserver 1.2 or higher.
> Servers 1.2 and higher always include randr 1.2 modes code.
> Therefore BUILD_XMODES will never be set to "yes".

Fair enough.  If anyone needs to be able to build the driver on older
servers, we can always fork off a new branch from before this change.

Reviewed-by: Aaron Plattner <aplattner at nvidia.com>

> There is no need to allow this driver to build from an arbitrary
> modes and parser tree outside the installed server.
> 
> This will sove the issue where "make dist" fails "out of the box"
> and requires manual fix-up on the build machine which is documented
> in the comapt/README file.
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  Makefile.am            |    2 +-
>  compat/.gitignore      |    2 --
>  compat/Makefile.am     |   16 ----------------
>  compat/README          |    7 -------
>  configure.ac           |   45 ---------------------------------------------
>  src/Makefile.am        |   23 +----------------------
>  src/local_xf86Rename.h |   23 -----------------------
>  7 files changed, 2 insertions(+), 116 deletions(-)
>  delete mode 100644 compat/.gitignore
>  delete mode 100644 compat/Makefile.am
>  delete mode 100644 compat/README
>  delete mode 100644 src/local_xf86Rename.h

There are a few RANDR_12_INTERFACE checks that could probably be deleted, plus I
think G80LoadPalette could probably be deleted as well, though somebody would
need to make sure that it still works correctly with xserver 1.2.

> I am aware it has recently been deprecated.

It's not exactly deprecated, we're just not adding support for Fermi or
DisplayPort.  Fixes for earlier chips are still relevant and won't be rejected
just because we're not adding support for newer chips.


More information about the xorg-devel mailing list