[PATCH video-xgi] Add Support-ARM, EXA acceleration,EDID,Custom Modes, Bugs fixed, ...

Fri Feb 5 05:55:23 PST 2010

On Fri, 2010-02-05 at 18:21 +0800, Jong Lin wrote:
> Hi Gaetan,
> 
> Do I need to send the correct patch again to xorg-devel at lists.x.org?
> 
> Could you please help to check the attachment sent by xorg-devel?
> 
> Do I need to break it down to small ones and resend again?

There is a limit on the size of e-mail that can be posted on the list.
Judging by the description of the patch, there are several new features
and multiple bug fixes in that single patch. The reason why we send
patches to the list is for them to be reviewed by other developers. They
will read the code and possibly find errors, raise issues and make
suggestions for improvement. 

It would be much easier for the reviewers if this work was broken down
into features (add support for...) and bug fixes and submitted in
different patches. It will also be much easier for you to make
modifications based on the comments from reviewers. The xgi module
maintainer should be able to provide you with more specific guidelines.

> 
>  
> 
> 
>                                    
> ______________________________________________________________________
> 
> From:xorg-devel-bounces at lists.x.org
> [mailto:xorg-devel-bounces at lists.x.org] On Behalf Of Gaetan Nadon
> Sent: Wednesday, January 27, 2010 10:05 PM
> To: Jong Lin
> Cc: xorg-devel at lists.x.org
> Subject: RE: [PATCH video-xgi] Add Support-ARM, EXA
> acceleration,EDID,Custom Modes, Bugs fixed, ...
> 
> 
> 
>  
> 
> On Wed, 2010-01-27 at 15:55 +0800, Jong Lin wrote: 
> 
> Could you please try on the attachment?
> 
> 
> 
> It applies without error. On Linux it shows a ^M character at the end
> of each line, which was there before. The XGI team may want to
> investigate further more and adopt common development practises. Some
> files are in one format and other files are in another.
> 
> 
> 
>  
> 
> 
> >                                   
> > ____________________________________________________________________
> > 
> > From:Jong Lin 
> > Sent: Wednesday, January 27, 2010 11:26 AM
> > To:'memsize at videotron.ca'
> > Cc:xorg-devel at lists.x.org
> > Subject: RE: [PATCH video-xgi] Add Support-ARM, EXA acceleration,
> > EDID,Custom Modes, Bugs fixed, ...
> > 
> > 
> > 
> >  
> > 
> > Hi Gaetan,
> > 
> > It might be caused by our editing source code on Windows platform.
> > 
> > It might be fixed by convert files by dos2unix.
> > 
> > How about your comment?
> > 
> >  
> > 
> > 
> >                                   
> > ____________________________________________________________________
> > 
> > From:xorg-devel-bounces at lists.x.org
> > [mailto:xorg-devel-bounces at lists.x.org] On Behalf Of Gaetan Nadon
> > Sent: Monday, January 25, 2010 9:43 PM
> > To:Jong Lin
> > Cc:xorg-devel at lists.x.org
> > Subject: Re: [PATCH video-xgi] Add Support-ARM, EXA acceleration,
> > EDID,Custom Modes, Bugs fixed, ...
> > 
> > 
> > 
> >  
> > 
> > On Mon, 2010-01-25 at 16:29 +0800, Jong Lin wrote: 
> > 
> > This patch includes the following enhancements and some bug fixings.
> > 
> > (1). Support ARM
> > 
> > (2). Support EXA acceleration
> > 
> > (3). Support EDID with I2C function
> > 
> > (4). Support Custom Modes of modeline
> > 
> > (5). Unify code for x86, PowerPC, ARM
> > 
> > 
> > I used 'git apply --check' to verify the patch would apply but it
> > doesn't I get errors like:
> > 
> > error: patch failed: src/init.c:1 
> > 
> > 
> >  
> >  
> > error: src/init.c: patch does not apply
> > 
> > 
> > 
> > The patch shows that the whole content of the init.c file has
> > changed, but I can't see any real code difference. Then I remembered
> > about code page issues when translators worked from different
> > platforms (Unix, Windows...). I checked the file with the 'file'
> > command:
> > 
> > 
> >  
> >  
> > init.c:        ASCII C program text, with CRLF line terminators
> > vb_ext.c:      ASCII C program text
> > vb_init.c:     ASCII C program text, with CRLF line terminators
> > vb_setmode.c:  ASCII C program text, with CRLF line terminators
> > xgi_accel.c:   ASCII C program text, with CRLF line terminators
> > xgi_cursor.c:  ASCII C program text
> > xgi_dac.c:     ASCII C program text
> > xgi_dga.c:     ASCII C program text
> > xgi_dri.c:     ASCII C program text
> > xgi_driver.c:  ASCII C program text, with CRLF, LF line terminators
> > xgi_opt.c:     ASCII C program text
> > xgi_setup.c:   ASCII C program text, with CRLF, LF line terminators
> > xgi_vb.c:      ASCII C program text
> > xgi_vga.c:     ASCII C program text, with CRLF line terminators
> > xgi_video.c:   ASCII C program text
> > xgi_videohw.c: ASCII C program text
> >  
> > 
> > 
> > 
> > It just so happens that the files giving errors are the one with
> > CRLF terminators. Most likely, xgi developers edit code on platforms
> > having different file formats. I did a quick scan on other drivers
> > and I have not seen files with CRLF terminators.
> > 
> > It's just a theory for now, most likely others have seen this before
> > and know of to fix it.
> > 
> > 
> > 
> 
> email message attachment
> 
> > -------- Forwarded Message --------
> > From: xorg-devel-bounces at lists.x.org
> > To: Jong Lin <jong_lin at xgitech.com>
> > Subject: Your message to xorg-devel awaits moderator approval
> > Date: Wed, 27 Jan 2010 15:57:09 +0800
> > 
> > 
> > 
> > Your mail to 'xorg-devel' with the subject
> > 
> >     RE: [PATCH video-xgi] Add Support-ARM, EXA acceleration, 
> > EDID,Custom Modes, Bugs fixed, ...
> > 
> > Is being held until the list moderator can review it for approval.
> > 
> > The reason it is being held:
> > 
> >     Message body is too big: 2570937 bytes with a limit of 100 KB
> > 
> > Either the message will get posted to the list, or you will receive 
> > notification of the moderator's decision.  If you would like to
> > cancel 
> > this posting, please visit the following URL:
> > 
> > 
> > http://lists.x.org/mailman/confirm/xorg-devel/11507d2971c6e0d13e5ab068a73e90d3be23df2e
> > 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20100205/f5921a9b/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20100205/f5921a9b/attachment.pgp 