<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> <TITLE>Your message to xorg-devel awaits moderator approval</TITLE> </HEAD> <BODY LINK="#0000ff"> On Fri, 2010-02-05 at 18:21 +0800, Jong Lin wrote: <BLOCKQUOTE TYPE=CITE> Hi Gaetan, Do I need to send the correct patch again to xorg-devel@lists.x.org? Could you please help to check the attachment sent by xorg-devel? Do I need to break it down to small ones and resend again? </BLOCKQUOTE> There is a limit on the size of e-mail that can be posted on the list. Judging by the description of the patch, there are several new features and multiple bug fixes in that single patch. The reason why we send patches to the list is for them to be reviewed by other developers. They will read the code and possibly find errors, raise issues and make suggestions for improvement. It would be much easier for the reviewers if this work was broken down into features (add support for...) and bug fixes and submitted in different patches. It will also be much easier for you to make modifications based on the comments from reviewers. The xgi module maintainer should be able to provide you with more specific guidelines. <BLOCKQUOTE TYPE=CITE>   </BLOCKQUOTE> <BLOCKQUOTE TYPE=CITE> <DIV ALIGN=center> <HR> </DIV> </BLOCKQUOTE> <BLOCKQUOTE TYPE=CITE> From:xorg-devel-bounces@lists.x.org [mailto:xorg-devel-bounces@lists.x.org] On Behalf Of Gaetan Nadon Sent: Wednesday, January 27, 2010 10:05 PM To: Jong Lin Cc: xorg-devel@lists.x.org Subject: RE: [PATCH video-xgi] Add Support-ARM, EXA acceleration,EDID,Custom Modes, Bugs fixed, ... </BLOCKQUOTE> <BLOCKQUOTE TYPE=CITE>   On Wed, 2010-01-27 at 15:55 +0800, Jong Lin wrote: Could you please try on the attachment? It applies without error. On Linux it shows a ^M character at the end of each line, which was there before. The XGI team may want to investigate further more and adopt common development practises. Some files are in one format and other files are in another.   </BLOCKQUOTE> <BLOCKQUOTE TYPE=CITE> <BLOCKQUOTE TYPE=CITE> <DIV ALIGN=center> <HR> </DIV> </BLOCKQUOTE> </BLOCKQUOTE> <BLOCKQUOTE TYPE=CITE> <BLOCKQUOTE TYPE=CITE> From:Jong Lin Sent: Wednesday, January 27, 2010 11:26 AM To:'memsize@videotron.ca' Cc:xorg-devel@lists.x.org Subject: RE: [PATCH video-xgi] Add Support-ARM, EXA acceleration, EDID,Custom Modes, Bugs fixed, ...   Hi Gaetan, It might be caused by our editing source code on Windows platform. It might be fixed by convert files by dos2unix. How about your comment?   </BLOCKQUOTE> </BLOCKQUOTE> <BLOCKQUOTE TYPE=CITE> <BLOCKQUOTE TYPE=CITE> <DIV ALIGN=center> <HR> </DIV> </BLOCKQUOTE> </BLOCKQUOTE> <BLOCKQUOTE TYPE=CITE> <BLOCKQUOTE TYPE=CITE> From:xorg-devel-bounces@lists.x.org [mailto:xorg-devel-bounces@lists.x.org] On Behalf Of Gaetan Nadon Sent: Monday, January 25, 2010 9:43 PM To:Jong Lin Cc:xorg-devel@lists.x.org Subject: Re: [PATCH video-xgi] Add Support-ARM, EXA acceleration, EDID,Custom Modes, Bugs fixed, ...   On Mon, 2010-01-25 at 16:29 +0800, Jong Lin wrote: This patch includes the following enhancements and some bug fixings. (1). Support ARM (2). Support EXA acceleration (3). Support EDID with I2C function (4). Support Custom Modes of modeline (5). Unify code for x86, PowerPC, ARM I used 'git apply --check' to verify the patch would apply but it doesn't I get errors like: error: patch failed: src/init.c:1 <PRE>     error: src/init.c: patch does not apply </PRE> The patch shows that the whole content of the init.c file has changed, but I can't see any real code difference. Then I remembered about code page issues when translators worked from different platforms (Unix, Windows...). I checked the file with the 'file' command: <PRE>     init.c:        ASCII C program text, with CRLF line terminators vb_ext.c:      ASCII C program text vb_init.c:     ASCII C program text, with CRLF line terminators vb_setmode.c:  ASCII C program text, with CRLF line terminators xgi_accel.c:   ASCII C program text, with CRLF line terminators xgi_cursor.c:  ASCII C program text xgi_dac.c:     ASCII C program text xgi_dga.c:     ASCII C program text xgi_dri.c:     ASCII C program text xgi_driver.c:  ASCII C program text, with CRLF, LF line terminators xgi_opt.c:     ASCII C program text xgi_setup.c:   ASCII C program text, with CRLF, LF line terminators xgi_vb.c:      ASCII C program text xgi_vga.c:     ASCII C program text, with CRLF line terminators xgi_video.c:   ASCII C program text xgi_videohw.c: ASCII C program text   </PRE> It just so happens that the files giving errors are the one with CRLF terminators. Most likely, xgi developers edit code on platforms having different file formats. I did a quick scan on other drivers and I have not seen files with CRLF terminators. It's just a theory for now, most likely others have seen this before and know of to fix it. </BLOCKQUOTE> </BLOCKQUOTE> <BLOCKQUOTE TYPE=CITE> <TABLE CELLSPACING="0" CELLPADDING="0" BORDER="1"> <TR> <TD> email message attachment </TD> </TR> </TABLE> <BLOCKQUOTE TYPE=CITE> -------- Forwarded Message -------- From: <A HREF="mailto:xorg-devel-bounces@lists.x.org">xorg-devel-bounces@lists.x.org</A> To: Jong Lin <<A HREF="mailto:Jong%20Lin%20%3cjong_lin@xgitech.com%3e">jong_lin@xgitech.com</A>> Subject: Your message to xorg-devel awaits moderator approval Date: Wed, 27 Jan 2010 15:57:09 +0800 Your mail to 'xorg-devel' with the subject     RE: [PATCH video-xgi] Add Support-ARM, EXA acceleration, EDID,Custom Modes, Bugs fixed, ... Is being held until the list moderator can review it for approval. The reason it is being held:     Message body is too big: 2570937 bytes with a limit of 100 KB Either the message will get posted to the list, or you will receive notification of the moderator's decision.  If you would like to cancel this posting, please visit the following URL:     <A HREF="http://lists.x.org/mailman/confirm/xorg-devel/11507d2971c6e0d13e5ab068a73e90d3be23df2e">http://lists.x.org/mailman/confirm/xorg-devel/11507d2971c6e0d13e5ab068a73e90d3be23df2e</A> </BLOCKQUOTE> </BLOCKQUOTE> </BODY> </HTML>