[PATCH modular 03/13] build.sh: allow user to specify an alternate bin directory

Gaetan Nadon memsize at videotron.ca
Wed Dec 29 17:56:05 PST 2010

On Wed, 2010-12-29 at 19:31 -0500, Trevor Woerner wrote:

> On Wed, Dec 29, 2010 at 10:44 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> > +# Set the default value for BINDIR
> > +if [ X"$BINDIR_SET" = X ]; then
> > +    BINDIR=$EPREFIX/bin
> > +fi
> I wonder if the above snippet (and all other such snippets from this
> patch set) could be moved into the setup_buildenv() function? I
> believe the purpose of that function is to define/setup various
> default values. Moving these snippets there too will keep all the
> variable defining/setting all in one place?

Yes, much better. Thanks

> I'm guessing you already thought of this, though, because you have
> added various checks to the setup_buildenv() function for these
> variables.

Nope, I had not thought about it.

> In the case where "build.sh -L" is called all this environment setup
> isn't required, and is one of the reasons why all that code was moved
> into that function.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101229/00abfb9f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101229/00abfb9f/attachment.pgp>

More information about the xorg-devel mailing list