<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Wed, 2010-12-29 at 19:31 -0500, Trevor Woerner wrote: <BLOCKQUOTE TYPE=CITE> <PRE> On Wed, Dec 29, 2010 at 10:44 AM, Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>> wrote: > +# Set the default value for BINDIR > +if [ X"$BINDIR_SET" = X ]; then > +    BINDIR=$EPREFIX/bin > +fi I wonder if the above snippet (and all other such snippets from this patch set) could be moved into the setup_buildenv() function? I believe the purpose of that function is to define/setup various default values. Moving these snippets there too will keep all the variable defining/setting all in one place? </PRE> </BLOCKQUOTE> Yes, much better. Thanks <BLOCKQUOTE TYPE=CITE> <PRE> I'm guessing you already thought of this, though, because you have added various checks to the setup_buildenv() function for these variables. </PRE> </BLOCKQUOTE> Nope, I had not thought about it. <BLOCKQUOTE TYPE=CITE> <PRE> In the case where "build.sh -L" is called all this environment setup isn't required, and is one of the reasons why all that code was moved into that function. </PRE> </BLOCKQUOTE> </BODY> </HTML>