[PATCHES] Multitouch v3 - please review/test

Chase Douglas chase.douglas at canonical.com
Tue Dec 21 08:53:06 PST 2010


On 12/17/2010 04:04 PM, Daniel Stone wrote:
> On Fri, Dec 17, 2010 at 03:59:30PM -0500, Chase Douglas wrote:
>> I haven't reviewed the protocol specification changes yet, nor have I
>> performed any code review.
> 
> Yeah, I should've removed your S-o-b/R-b tags from the significantly
> changed parts -- my bad.

I'm actually not quite clear what should happen when patches are
co-developed. SOB is a statement that the code may be incorporated under
the license of the project, so I always thought that the SOB may remain
after further modifications since the code is still incorporable. The RB
tag should probably be removed though.

>> I built some test packages, but I found that
>> touches sometimes do not come through. I believe I saw some touches from
>> my magic trackpad on the first run of xinput test-xi2, but I can't get
>> any more now. Seems like it gets stuck. I think I may have seen the same
>> issue during one test of my touchscreen too.
> 
> Hmm, I haven't seen that, but admittedly have been bouncing my X server
> up and down rather than doing sustained long-term testing.  I'll have a
> closer look next week, but any insight you'd have (especially any easy
> way to reproduce, or even just which environment/test clients you were
> using) would be great.

I wish I had more info, but alas I dont :(. The only thing I can say is
that I am using my Ubuntu 10.10 packages.

-- Chase


More information about the xorg-devel mailing list