xdm <-> xdmcp

Adam Jackson ajax at redhat.com
Mon Dec 20 05:56:50 PST 2010


On Sat, 2010-12-18 at 10:59 -0500, Gaetan Nadon wrote:
> On Fri, 2010-12-17 at 08:35 -0500, Trevor Woerner wrote: 
> > Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find
> > the following symbols:
> >      _XdmcpAuthSetup
> >      _XdmcpAuthDoIt
> >      _XdmcpWrapperToOddParity
> 
> I don't understand why this patch, and a few other similar ones, were
> pushed as they were Nacked by 4 reviewers. They should be reverted and
> redone properly. The problem that occurred is exactly what happens
> when relying on a naming convention. Sooner or later it will break.
> All other libraries do it in the source code.

The ones I pushed hadn't been nacked, I didn't think?  Regardless, yeah,
revert.

- ajax



More information about the xorg-devel mailing list