[PATCH] xfree86: always report the input options before initialising the device.
peter.hutterer at who-t.net
Mon Dec 13 16:12:27 PST 2010
On Tue, Dec 14, 2010 at 02:26:04AM +0100, Simon Thum wrote:
> On 12/13/2010 03:24 PM, Dan Nicholson wrote:
> > On Sun, Dec 12, 2010 at 7:20 PM, Peter Hutterer
> > <peter.hutterer at who-t.net> wrote:
> >> After collecting the driver's default options, report the list of options
> >> set for the device before calling PreInit(). This helps with debugging those
> >> cases where options are not merged correctly.
> >> xf86OptionListReport reports with verbosity 5, higher than the default
> >> verbosity so this won't generate logspam in the default case.
> >> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > Seems like a good idea. I guess it's normally the driver that logs
> > some of the option settings?
> Those actually used get thrashed out in ParseOptionValue(). But for
> debugging a setup it's probably still a good idea.
> Reviewed-by: Me ;)
the options that are logged by the driver are those passed into
xf86SetFooOption(), provided the option is set. this doesn't necessarily log
all options though, the xf86OptionListReport is especially handy to find
settings where an option is set but ignored by the driver.
synaptics used to have xf86OptionListReport in the driver before I kicked it
out recently, but having this in one place in the server seems a bit more
More information about the xorg-devel