[PATCH] xfree86: always report the input options before initialising the device.

Simon Thum simon.thum at gmx.de
Mon Dec 13 17:26:04 PST 2010


On 12/13/2010 03:24 PM, Dan Nicholson wrote:
> On Sun, Dec 12, 2010 at 7:20 PM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
>> After collecting the driver's default options, report the list of options
>> set for the device before calling PreInit(). This helps with debugging those
>> cases where options are not merged correctly.
>>
>> xf86OptionListReport reports with verbosity 5, higher than the default
>> verbosity so this won't generate logspam in the default case.
>>
>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> Seems like a good idea. I guess it's normally the driver that logs
> some of the option settings?
Those actually used get thrashed out in ParseOptionValue(). But for
debugging a setup it's probably still a good idea.

Reviewed-by: Me ;)

Cheers,

Simon


More information about the xorg-devel mailing list