[PATCH font-util] XORG_FONT_REQUIRED_PROG: should stop when program is missing #14436

[Jesse Adkins]

On Fri, Aug 27, 2010 at 5:24 PM, Gaetan Nadon <memsize at videotron.ca> wrote:

> The macro was designed to test for a program and, when missing, stop
> the configuration. The first parameter to the macro is a variable
> name which is used by AC_PATH_PROG to store the program path.
> The test failed to reference the variable content, it tested the
> variable name which is never blank.
>
> BDFTOPCF MKFONTSCALE MKFONTDIR COMPRESS and UCS2ANY were affected.
>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  fontutil.m4.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fontutil.m4.in b/fontutil.m4.in
> index 616366f..75feff8 100644
> --- a/fontutil.m4.in
> +++ b/fontutil.m4.in
> @@ -138,7 +138,7 @@ AC_DEFUN([XORG_FONT_CHECK_ENCODING_LIST],[
>
>  AC_DEFUN([XORG_FONT_REQUIRED_PROG],[
>        AC_PATH_PROG($1, $2)
> -       if test x"$1" = x; then
> +       if test x"$$1" = x; then
>                AC_MSG_ERROR([$2 is required to build $PACKAGE_NAME.])
>        fi
>  ])
> --
> 1.6.0.4
>
>
Works for me, and looks a whole lot better than my patch.

Tested-by: Jesse Adkins <jesserayadkins at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100827/633e2db9/attachment.htm>