[PATCH font-util] XORG_FONT_REQUIRED_PROG: should stop when program is missing #14436

[Alan Coopersmith]

Gaetan Nadon wrote:
> The macro was designed to test for a program and, when missing, stop
> the configuration. The first parameter to the macro is a variable
> name which is used by AC_PATH_PROG to store the program path.
> The test failed to reference the variable content, it tested the
> variable name which is never blank.
> 
> BDFTOPCF MKFONTSCALE MKFONTDIR COMPRESS and UCS2ANY were affected.
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  fontutil.m4.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fontutil.m4.in b/fontutil.m4.in
> index 616366f..75feff8 100644
> --- a/fontutil.m4.in
> +++ b/fontutil.m4.in
> @@ -138,7 +138,7 @@ AC_DEFUN([XORG_FONT_CHECK_ENCODING_LIST],[
>  
>  AC_DEFUN([XORG_FONT_REQUIRED_PROG],[
>  	AC_PATH_PROG($1, $2)
> -	if test x"$1" = x; then
> +	if test x"$$1" = x; then
>  		AC_MSG_ERROR([$2 is required to build $PACKAGE_NAME.])
>  	fi
>  ])

Thanks - I was wondering if something like this would be a simpler and
more compatible fix than the patches proposed on the bug report, but hadn't
had time to check.   If that works, then it looks good to me.

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System