[PATCH v2] input: constify valuators passed in by input drivers.

Daniel Stone daniel at fooishbar.org
Mon Aug 9 22:05:48 PDT 2010


On Tue, Aug 10, 2010 at 01:59:13PM +1000, Peter Hutterer wrote:
> GPE modifies the valuators array passed in. Which means any driver using
> e.g. xf86PostButtonEventP(..., valuators) twice to emulate a button click
> will provide garbage data on the second run.
> 
> Constify the argument, and do the same for keyboard and proximity events.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Changes to v1:
> - valuators array malloc'ed now instead of the previous 
>   "int valuators[num_valuators]"

malloc() in a signal handler ftl - I guess you could just have a
static int copied_valuators[MAX_VALUATORS].

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100810/23de648b/attachment.pgp>


More information about the xorg-devel mailing list