[PATCH v2] input: constify valuators passed in by input drivers.

Keith Packard keithp at keithp.com
Mon Aug 9 21:21:34 PDT 2010


On Tue, 10 Aug 2010 13:59:13 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> GPE modifies the valuators array passed in. Which means any driver using
> e.g. xf86PostButtonEventP(..., valuators) twice to emulate a button click
> will provide garbage data on the second run.

I'm good with the bug fix, but I think we should leave the API change
until after 1.9. Yeah, it's just the addition of 'const', but still, it
seems like the real value is to try compiling with 'const' and make sure
the code actually doesn't modify the argument, right?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100809/78a46749/attachment.pgp>


More information about the xorg-devel mailing list