[PATCH resent * 2] xfree86: fix not reached code in fi1236 driver from i2c

[Keith Packard]

On Wed, 21 Apr 2010 18:28:13 +0300, Tiago Vignatti <tiago.vignatti at nokia.com> wrote:
> This issue was introduced in the first dump of the code in 2004. I haven't
> check what's the correct fix for it so I simply kept the behaviour of someone
> calling this and removed the unreachable code.
> 
> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> ---
> Keith, this patch is the last in my queue of Coverity findings. I sent twice
> and no one commented so far, so I'm expecting an answer from the RM
> now.

Yeah, I looked at the code and your patch seems fine; this driver polls
the hardware until the tuner locks or gives up, recording the result in
last_afc_hint, so it seems correct to simply return the most recently
received value.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100421/111279ee/attachment.pgp>