[PATCH resent * 2] xfree86: fix not reached code in fi1236 driver from i2c

Tiago Vignatti tiago.vignatti at nokia.com
Wed Apr 21 08:28:13 PDT 2010


This issue was introduced in the first dump of the code in 2004. I haven't
check what's the correct fix for it so I simply kept the behaviour of someone
calling this and removed the unreachable code.

Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
---
Keith, this patch is the last in my queue of Coverity findings. I sent twice
and no one commented so far, so I'm expecting an answer from the RM now.

For me it's straighforward clean-up and IMHO we should apply it, if not remove
fi1236 driver support.


 hw/xfree86/i2c/fi1236.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/hw/xfree86/i2c/fi1236.c b/hw/xfree86/i2c/fi1236.c
index 7c39edb..61224ea 100644
--- a/hw/xfree86/i2c/fi1236.c
+++ b/hw/xfree86/i2c/fi1236.c
@@ -398,10 +398,6 @@ int TUNER_get_afc_hint(FI1236Ptr f)
 {
 if(f->afc_timer_installed)return TUNER_STILL_TUNING;
 return f->last_afc_hint;
-if(f->type==TUNER_TYPE_MT2032)
-	return MT2032_get_afc_hint(f);
-	else
-	return FI1236_get_afc_hint(f);
 }
 
 static void MT2032_dump_status(FI1236Ptr f)
-- 
1.6.0.4



More information about the xorg-devel mailing list