[PATCH 2/6] exa: clean up some more code

Michel Dänzer michel at daenzer.net
Sun Mar 1 03:01:29 PST 2009


On Son, 2009-03-01 at 11:53 +0100, Maarten Maathuis wrote:
> >> The reason for this entire patchset was to make everything more
> >> strict.
> >
> > That's okay in principle, but note that e.g. we only wrap CreatePixmap
> > (and allocate an ExaPixmapPriv) if the driver sets the
> > EXA_OFFSCREEN_PIXMAPS flag...
> 
> How that does that work anyway, acceleration without EXA_OFFSCREEN_PIXMAPS?

Not sure, just saying. I thought the geode driver wasn't setting this
flag at least under some circumstances, but grep disagrees, and the only
related change I can find in Git is commit
c6339a360b611514155e5101dc2c5bc6472d8865 ('[LX] - RandR 1.2 updates').
It says 'Remove a flag that was making EXA pixmaps break horribly.', but
in the diff I can only see the addition of a commented instance of the
flag...


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list