[PATCH 2/6] exa: clean up some more code

Maarten Maathuis madman2003 at gmail.com
Sun Mar 1 02:53:30 PST 2009


>> The reason for this entire patchset was to make everything more
>> strict.
>
> That's okay in principle, but note that e.g. we only wrap CreatePixmap
> (and allocate an ExaPixmapPriv) if the driver sets the
> EXA_OFFSCREEN_PIXMAPS flag...

How that does that work anyway, acceleration without EXA_OFFSCREEN_PIXMAPS?

>
>> If you want i can fix one or two minor bugs in this patchset and put a
>> combined patch on bug 20212. I'm guessing that should be fixed too.
>
> We should try to find a minimal fix for the bug, so it can hopefully be
> backported to the 1.6 branch.

While minimal fixes are nice, you first have to know what the issue
is, and should the corrected patchset fix this, then you know where to
look.

>
>
> --
> Earthling Michel Dänzer           |                http://www.vmware.com
> Libre software enthusiast         |          Debian, X and DRI developer
>


More information about the xorg-devel mailing list