Patches to cleanup panoramix compile issues

Peter Hutterer peter.hutterer at who-t.net
Thu Feb 12 22:36:40 PST 2009


On Fri, Feb 13, 2009 at 04:26:53AM -0200, Paulo César Pereira de Andrade wrote:
> Benjamin Close wrote:
> > Hi folks these patches fix the compilation issues with xserver as reported
> > at http://www.mail-archive.com/xorg@lists.freedesktop.org/msg04615.html
> >
> > The xserver should only be using the header from the proto rather than
> > pulling in the header from libXinerama which also has Xlib related code in
> > it.
> > However the proto doesn't have the required defines. Hence we shift the
> > defines
> > back to proto, cleanup unneeded code in the lib and some stale includes in
> > the server
> > making things compile out the box and breaking the dependancy of xserver
> > on libXinerama
> 
>   I think Ian Romanick also cherry-pick'ed my git master patch into
> branch 1.6 for this problem today.
>   I feel your patch is correct (and I did not implement something
> similar due to being afraid of it breaking things outside of Xorg),
> but it most likely will cause similar problems with branch 1.6 or
> older, if one wants to compile non git master server with git master
> libraries/proto.

we cannot make guarantees that a released version of a component works with
components compiled from the git master branches.
 
The general rule is that if you want one component from git, be prepared to
get other ones from git as well.

Cheers,
  Peter


More information about the xorg-devel mailing list