Patches to cleanup panoramix compile issues

Paulo César Pereira de Andrade pcpa at mandriva.com.br
Thu Feb 12 22:26:53 PST 2009


Benjamin Close wrote:
> Hi folks these patches fix the compilation issues with xserver as reported
> at http://www.mail-archive.com/xorg@lists.freedesktop.org/msg04615.html
>
> The xserver should only be using the header from the proto rather than
> pulling in the header from libXinerama which also has Xlib related code in
> it.
> However the proto doesn't have the required defines. Hence we shift the
> defines
> back to proto, cleanup unneeded code in the lib and some stale includes in
> the server
> making things compile out the box and breaking the dependancy of xserver
> on libXinerama

  I think Ian Romanick also cherry-pick'ed my git master patch into
branch 1.6 for this problem today.
  I feel your patch is correct (and I did not implement something
similar due to being afraid of it breaking things outside of Xorg),
but it most likely will cause similar problems with branch 1.6 or
older, if one wants to compile non git master server with git master
libraries/proto.

  Anyway, while at it, I suggest also working on non *Xext.h headers
or included in the X Server compiltation. Or inside the X Server, see
for example Xext/securitysrv.h

Paulo



More information about the xorg-devel mailing list