[PATCH 4/4] EXA: Restrict the regions that need to be migrated for composite fallback for src / mask pictures.

Michel Dänzer michel at daenzer.net
Mon Dec 28 07:12:37 PST 2009


On Mon, 2009-12-28 at 16:05 +0100, Maarten Maathuis wrote: 
> 2009/12/28 Michel Dänzer <michel at daenzer.net>:
> > On Mon, 2009-12-28 at 13:51 +0100, Maarten Maathuis wrote:
> >>
> >> I don't quite get why this has to be in ExaScreenPrivRec, it seems to
> >> be only used in one function.
> >
> > It allows using the swap() macro. I agree it's not strictly necessary,
> > but frankly I don't see the big deal.
> 
> I meant the stuff below, sorry if that was unclear.

The source and mask regions are used in two functions,
ExaPrepareCompositeReg() and ExaSrcValidate(). The latter is called by
the former via miComputeCompositeRegion(), so there has to be some kind
of EXA specific communications channel between the two. Thomas
originally added a RegionRec to the pixmap private, but that would
indeed waste memory, as at most two RegionRecs are needed at any time.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list