[PATCH 4/4] EXA: Restrict the regions that need to be migrated for composite fallback for src / mask pictures.

Maarten Maathuis madman2003 at gmail.com
Mon Dec 28 07:05:47 PST 2009


2009/12/28 Michel Dänzer <michel at daenzer.net>:
> On Mon, 2009-12-28 at 13:51 +0100, Maarten Maathuis wrote:
>> 2009/12/28 Michel Dänzer <michel at daenzer.net>:
>> > From: Thomas Hellstrom <thellstrom at vmware.com>
>> >
>> > [ Michel: Minor fixups to address compiler warnings ]
>> >
>> > Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
>> > Signed-off-by: Michel Dänzer <daenzer at vmware.com>
>> > ---
>> >  exa/exa_priv.h    |   10 +++
>> >  exa/exa_unaccel.c |  231 +++++++++++++++++++++++++++++++++++++++++++----------
>> >  2 files changed, 200 insertions(+), 41 deletions(-)
>> >
>> > diff --git a/exa/exa_priv.h b/exa/exa_priv.h
>> > index c559b9a..21d9646 100644
>> > --- a/exa/exa_priv.h
>> > +++ b/exa/exa_priv.h
>> > @@ -165,6 +165,7 @@ typedef struct {
>> >     BitmapToRegionProcPtr        SavedBitmapToRegion;
>> >     CreateScreenResourcesProcPtr SavedCreateScreenResources;
>> >     ModifyPixmapHeaderProcPtr    SavedModifyPixmapHeader;
>> > +    SourceValidateProcPtr        SavedSourceValidate;
>> >  #ifdef RENDER
>> >     CompositeProcPtr             SavedComposite;
>> >     TrianglesProcPtr            SavedTriangles;
>>
>> I don't quite get why this has to be in ExaScreenPrivRec, it seems to
>> be only used in one function.
>
> It allows using the swap() macro. I agree it's not strictly necessary,
> but frankly I don't see the big deal.

I meant the stuff below, sorry if that was unclear.

>
>
> --
> Earthling Michel Dänzer           |                http://www.vmware.com
> Libre software enthusiast         |          Debian, X and DRI developer
>


More information about the xorg-devel mailing list