[PATCH] Convert checks for PC98 support from platform #ifdefs to configure flag
Tiago Vignatti
tiago.vignatti at nokia.com
Sat Dec 19 09:45:03 PST 2009
On Sat, Dec 19, 2009 at 03:55:25AM +0100, ext Alan Coopersmith wrote:
> Daniel Stone wrote:
> > Yeah. It's almost kind of a standard PC, but has bizzare weird quirks
> > for everything, hence the #ifdef city. There aren't _that_ many of them
> > still around, but definitely still a few -- I remember merging patches
> > to fix PC98 support from Bugzilla at some point. Hopefully we can can
> > support for it in a couple of years or so, but at the moment I guess
> > just not actively breaking it should be fine.
>
> Well, at least those like Tiago who know they'll never need it can now
> pass --disable-pc98 to save a few instructions and a BIOS read.
>
> At what point the upstream default should become disabled for all and
> require those who need it in their distros to enable is another question.
>
right.
But I was not questioning about the existence of PC86 code in the server. My
problem is when I'm going through the code and see a zillions of macros that
I'd like to know just _what_ they are. It's pretty useful to understand if I
need to care or not about some particular piece of code, when doing
development - I don't want to google for PC86, trying to guess what's it.
So if there's a comment somewhere, saying exactly what you guys explained
here, helps a lot. Just it :)
Tiago
More information about the xorg-devel
mailing list