[PATCH 36-41/41] apm .. vesa: configure.ac: sdkdir usage duplicates the sdk include dir

[Gaetan Nadon]

Hi,

There are 41 driver modules with the line:

        sdkdir=$(pkg-config --variable=sdkdir xorg-server)


Following up on review
http://lists.x.org/archives/xorg-devel/2009-November/003711.html


        From Dan Nicholson:
        This should be
        
        sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
        
        1. The user may need to use a specific pkg-config or pass custom
        arguments to it. Think multiarch or cross-compiling scenarios.
        
        2. Backticks (``) are supported by all shells while $() command
        substitution is for strictly POSIX conforming shells. We don't
        need to
        limit ourselves to that subset.

There are 4 modules who are not using that line at all. Rather than
making dead code more portable, this patch removes this statement. I
have done extensive grepping and tested with make distcheck:


        apm, ark, dummy, vesa


In addition, the sdkdir was passed in INCLUDES. The sdkdir is already
included in XORG_CFLAGS. There were 2 copies of sdkdir in the Makefile
and after the patch there is only one.

The reference patch is video-vesa



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20091217/a7c698fe/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure.ac-sdkdir-usage-duplicates-the-sdk-includ.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091217/a7c698fe/attachment.bin