<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> Hi, There are 41 driver modules with the line: <BLOCKQUOTE> <TT>sdkdir=$(pkg-config --variable=sdkdir xorg-server)</TT> </BLOCKQUOTE> Following up on review <A HREF="http://lists.x.org/archives/xorg-devel/2009-November/003711.html">http://lists.x.org/archives/xorg-devel/2009-November/003711.html</A> <BLOCKQUOTE> <TT>From Dan Nicholson:</TT> <TT>This should be</TT> <TT>sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`</TT> <TT>1. The user may need to use a specific pkg-config or pass custom</TT> <TT>arguments to it. Think multiarch or cross-compiling scenarios.</TT> <TT>2. Backticks (``) are supported by all shells while $() command</TT> <TT>substitution is for strictly POSIX conforming shells. We don't need to</TT> <TT>limit ourselves to that subset.</TT> </BLOCKQUOTE> There are 4 modules who are not using that line at all. Rather than making dead code more portable, this patch removes this statement. I have done extensive grepping and tested with make distcheck: <BLOCKQUOTE> <TT>apm, ark, dummy, vesa</TT> </BLOCKQUOTE> In addition, the sdkdir was passed in INCLUDES. The sdkdir is already included in XORG_CFLAGS. There were 2 copies of sdkdir in the Makefile and after the patch there is only one. The reference patch is video-vesa </BODY> </HTML>