xf86-video-intel: uxa/uxa-render.c

Chris Wilson ickle at kemper.freedesktop.org
Wed Jan 27 12:36:26 PST 2010


 uxa/uxa-render.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 918151a7955c26174db80b775205f6ffb4f44ab6
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Jan 27 20:33:08 2010 +0000

    uxa: Fix compatible_formats() for OVER
    
    In separating the boolean logic out into a separate function, dc6522dd,
    I reversed the sense of one particular test:
    
      src->format == dst->format
    
    The OVER optimisation is only valid if the src and dst formats match,
    but not always.
    
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/uxa/uxa-render.c b/uxa/uxa-render.c
index 512ac02..68b406e 100644
--- a/uxa/uxa-render.c
+++ b/uxa/uxa-render.c
@@ -994,8 +994,8 @@ compatible_formats (CARD8 op, PicturePtr dst, PicturePtr src)
 		if (src->alphaMap || dst->alphaMap)
 			return 0;
 
-		if (src->format == dst->format)
-			return 1;
+		if (src->format != dst->format)
+			return 0;
 
 		if (src->format == PICT_x8r8g8b8 || src->format == PICT_x8b8g8r8)
 			return 1;


More information about the xorg-commit mailing list