xf86-video-intel: src/i830_debug.c

Carl Worth cworth at kemper.freedesktop.org
Mon Aug 31 09:30:51 PDT 2009


 src/i830_debug.c |    2 --
 1 file changed, 2 deletions(-)

New commits:
commit 5812531e08147576de776b2dd64e7f94c08eb851
Author: Carl Worth <cworth at cworth.org>
Date:   Fri Jul 31 11:20:23 2009 -0700

    debug: i830_valid_command: Return invalid for subopcodes with no name
    
    Previously the code would always return the count, before ever looking
    into the _3d_cmds table to see if there was actually a valid command.
    
    Thanks to Alan Coopersmith who reported that the code was confusing
    parfait:
    
    https://bugs.freedesktop.org/show_bug.cgi?id=21666

diff --git a/src/i830_debug.c b/src/i830_debug.c
index 1333796..cf3f439 100644
--- a/src/i830_debug.c
+++ b/src/i830_debug.c
@@ -2113,8 +2113,6 @@ i830_valid_command (uint32_t cmd)
 	    count = 1;
 	else
 	    count = (cmd & 0xff) + 2;
-	if (pipeline_type <= 3)
-	    return count;
 	if (!_3d_cmds[pipeline_type][opcode][subopcode].name)
 	    return -1;
 	break;


More information about the xorg-commit mailing list