Was |int| always thought to be 32bit ?

Roland Mainz roland.mainz at nrubsig.org
Mon Apr 25 19:55:07 PDT 2005


"Mike A. Harris" wrote:
[snip]
> Since we're using dlloader in X11R7, and X11R7 is a major release of
> the X Window System, it would seem that now is the time to make as
> many major changes as possible, in particular those that change the
> ABI.  Existing XFree86 4.x server modules and xorg 6.[78] modules
> are not likely going to work in X11R7 anyway.  By overcoming as many
> limitations as possible in X11R7, we can capitalize on the opportunity
> to do more things "right", and perhaps remove a bunch of cruft from
> the code.  If not, we can at least fix major bugs that require ABI
> changes.
> 
> MAXSCREENS is perhaps another one that could be fixed if it hasn't
> been checked into CVS already.

Some other items:
- MAXFORMATS should be increased (or made dynamically)
- Adjust colormap and consumers (e.g. |VisualRec|, |SHAREDCOLOR|) to
work properly with more than 2^14colors (it's a |signed short| right now
but thanks to integer overflows elsewhere in the code the maximum
possible is 2^14 and not 2^15 right now) as preparation for the
BIGCOLORMAP and COLORSPACE extensions
- DDX should free Pixmaps using the |FreePixmap()| function (I have a
patch in the alloc-pixmap-via-mmap() bug) to have a clear counterpart to
|AllocPixmap()|, as preparation for XineramaV2 and VectorMap extensions
and to have a central place where pixmaps get deallocated (may be
usefull for debugging, right now the Pixmap structure is simply
deallocated using |xfree()| and you have to track-down manually the
places where this is being done... ;-().
- |ColormapRec| has the following item:
-- snip --
    pointer     devPriv;
    DevUnion    *devPrivates;   /* dynamic devPrivates added after
devPriv
                                   already existed - must keep devPriv
*/
} ColormapRec;
-- snip --
I assume that |devPriv| can go away, right ? Similar constructs can be
found in |PixmapRec|, |ScreenRec| etc...

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)


More information about the xorg-arch mailing list