[Mesa-dev] [PATCH 4/4] radv: fix dumping compute shader on the graphics queue

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu May 24 21:01:22 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

for the series.

On Thu, May 24, 2018 at 1:09 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> The graphics pipeline can be NULL.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_debug.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c
> index c84e3be25bb..5a9b43644ed 100644
> --- a/src/amd/vulkan/radv_debug.c
> +++ b/src/amd/vulkan/radv_debug.c
> @@ -540,12 +540,15 @@ radv_dump_graphics_state(struct radv_pipeline *graphics_pipeline,
>  {
>         VkShaderStageFlagBits active_stages;
>
> -       if (!graphics_pipeline)
> -               return;
> -
> -       active_stages = graphics_pipeline->active_stages;
> +       if (graphics_pipeline) {
> +               active_stages = graphics_pipeline->active_stages;
> +               radv_dump_pipeline_state(graphics_pipeline, active_stages, f);
> +       }
>
> -       radv_dump_pipeline_state(graphics_pipeline, active_stages, f);
> +       if (compute_pipeline) {
> +               active_stages = VK_SHADER_STAGE_COMPUTE_BIT;
> +               radv_dump_pipeline_state(compute_pipeline, active_stages, f);
> +       }
>  }
>
>  static void
> --
> 2.17.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list